[bisq-network/bisq] Bisq doesn't validate XMR addresses (#1652)
notifications at github.com
Thu Feb 14 11:57:23 UTC 2019
Sure, it will be zero-dependency code, including own Keccak1600 hashing class and Monero Base58 decoder.
What way would you prefer:
1. Place `Keccak1600` and `MoneroBase58` private classes right in the `CryptonoteAddressValidator.java` source.
Given that both won't be used elsewhere in the bitsq codebase, looks good to me.
Though might be somewhat less appropriate from Bisq code organization point of view.
2. Place `Keccak1600` and `MoneroBase58` classes in `bisq.common.crypto`
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the bisq-github