[bisq-network/bisq] Use NonMMappedSPVBlockStore on windows. (#2403)

Manfred Karrer notifications at github.com
Thu Feb 14 21:15:59 UTC 2019

I did some very basic test with an older not synced app on mainnet with using NonMMappedSPVBlockStore and SPVBlockStore. 2318 blocks where downloaded.
As I am on OSX so I just changed the if switch to enable NonMMappedSPVBlockStore.

I had Bitcoin core locally to avoid too much influence from network conditions.
I run 3 times with replacing the original outdated data directory to trigger the  download of all 2318 blocks:

SPVBlockStore:   51417 ms, 68965 ms, 68922 ms
NonMMappedSPVBlockStore:   92405 ms, 83738 ms, 71824 ms

So NonMMappedSPVBlockStore is a bit slower but not too critical.
Of course that is just one use case and is not sufficient to be sure if there is not more serious performance degradation, but I think it is ok to take the risk to merge that now.

I would prefer to not apply that to all OS but keep it as it is only for Windows.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190214/b88b2f74/attachment.html>

More information about the bisq-github mailing list