[bisq-network/bitcoinj] Clone transaction before committing to wallet (#21)

[sqrrm]

@ManfredKarrer I think it's quite clear that having the same tx instance in multiple wallets in bitcoinj is not how it's intended. When transactions are received from blocks they're cloned, see AbstractBlockChain:882. I think the reason they're not cloned when received from the broadcast callback is an oversight from the wallet developer.

The connected outputs are only set after a tx enters the wallet from what I understand. This also fits with how the external txs are cloned when added to multiple wallets.

I can still understand your hesitation to merge this too soon, but I think the conclusions are wrong regarding the risks and how the bitcoinj wallet works. Since we're already doing the cloning when publishing from the BSQ wallet it's not extremely urgent to fix this, but as mentioned before, I think it's worth fixing before going live on mainnet.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bitcoinj/pull/21#issuecomment-452121415
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190107/b2460d46/attachment.html>