[bisq-network/bisq-website] Translate website to Portuguese (#190)
erciccione
notifications at github.com
Tue Jul 9 15:29:06 UTC 2019
erciccione commented on this pull request.
> Add the "_tr" suffix to signal that they're the translated versions
I think this approach is confusing. Wouldn't be better to have a folder called `i18n` or something like that, where put all the translations? There could be a folder called `pt-pt` and all the portuguese translations could go in there, same for the other languages.
> **could we change the pt_PT directory to just pt? I think it would help URLs would look cleaner.**
I agree with @huey735, better use pt_PT, it's a better standard and avoid problems in the future (same potential issue with Chinese)
> do we want to keep URLs in English?
I think they should be kept in english.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/190#pullrequestreview-259583692
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190709/ac2df609/attachment.html>
More information about the bisq-github
mailing list