[bisq-network/bisq] List Emercoin (EMC) (#2961)

[Bernard Labno]

blabno requested changes on this pull request.

NACK per comments

> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.asset.coins;
+
+import bisq.asset.Coin;
+import bisq.asset.DefaultAddressValidator;
+
+public class Emercoin extends Coin {
+
+    public Emercoin() {
+        super("Emercoin", "EMC", new DefaultAddressValidator());

Do not use deprecated validator.

> + * Bisq is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.asset.coins;
+
+import bisq.asset.AbstractAssetWithDefaultValidatorTest;
+
+public class EmercoinTest extends AbstractAssetWithDefaultValidatorTest {
+
+    public EmercoinTest() {

Test class is missing test methods.

> @@ -131,6 +131,7 @@ public static void setBaseCurrencyCode(String baseCurrencyCode) {
         result.add(new CryptoCurrency("BEAM", "Beam"));
         result.add(new CryptoCurrency("DASH", "Dash"));
         result.add(new CryptoCurrency("DCR", "Decred"));
+        result.add(new CryptoCurrency("EMC", "Emercoin"));

Do not touch this file.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2961#pullrequestreview-262901693
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190717/24a44599/attachment.html>