[bisq-network/bisq] Fix missing balance at restore from seed words (#2517)

[Oscar Guindzberg]

oscarguindzberg commented on this pull request.



>              persist();
         }
+
+        // We add a confidence listener to get notified about potential new transactions and
+        // add an address entry list in case it does not exist yet. This is mainly needed for restore from seed words
+        // but can help as well in case the addressEntry list would miss an address where the wallet was received
+        // funds (e.g. if the user sends funds to an address which has not been provided in the main UI - like from the
+        // wallet details window).
+        wallet.addTransactionConfidenceEventListener((w, tx) -> {

TransactionConfidenceEventListener does the job but it seems to be an overkill. TransactionConfidenceEventListener is invoked for each wallet tx every time its "confidence" is updated (eg, when included in a block and every time a new block is mined on top of that block for the next 100 blocks).

Probably you want to use WalletCoinsReceivedEventListener and WalletCoinsSentEventListener (and  ScriptsChangeEventListener if you use the watched script feature of Wallet) instead to be notified of new addresses.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2517#pullrequestreview-212544620
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190308/c75f9981/attachment.html>