[bisq-network/bisq] (1/8) [TESTS] Add tests for P2PDataStorage in order to safely refactor (#3554)

[Julian Knutsen]

I've taken your feedback on splitting up the tests and the result is in #3587. There are now 6 separate test files that test separate entry points or functionality and a few additional helper classes that are shared between tests. I've also added plenty of JavaDocs to help future developers understand how the tests work and what they are testing.

As I mentioned in the (9/9) PR, I would prefer to leave this split to the end of my request stack due to the number of merges that would be required in the interim pull requests. If the maintainer isn't interested in the refactor I can possibly merge the split back to this point so you guys can have the tests moving forward.

Thanks for reviewing my work and giving feedback.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3554#issuecomment-552129372
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191109/a323474f/attachment.html>