[bisq-network/bisq] PaymentAccount object removal from ObservableSet issue (#3572)

[Florian Reimair]

freimair requested changes on this pull request.

great. Now testing is good for something.

Could you try if my `@EqualsAndHashCode.Exclude` suggestion works? and if yes, update the PR accordingly?

> +    @Override
+    public boolean equals(Object o) {
+        if (this == o) return true;
+        if (o == null || getClass() != o.getClass()) return false;
+        PaymentAccount that = (PaymentAccount) o;
+        return creationDate == that.creationDate &&
+                id.equals(that.id);
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(id, creationDate);
+    }
+

I would rather see a simple
```
@EqualsAndHashSode.Exclude
```
added to the `accountName` field rather than getting rid of lombok at all.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3572#pullrequestreview-314880522
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191111/5315a2a5/attachment.html>