[bisq-network/bisq] Remove redundant interfaces from FilterWindow and SendAlertMessageWindow (#3617)

Christoph Atteneder notifications at github.com
Tue Nov 19 12:46:51 UTC 2019


> @ripcurlx I see a few places where business logic is triggered directly in a window, for example:
> 
> * [SignPaymentAccountsWindow](https://github.com/bisq-network/bisq/blob/df6812a4c958553cfaf4587bf814de9d11be1a87/desktop/src/main/java/bisq/desktop/main/overlays/windows/SignPaymentAccountsWindow.java#L283)
> * [DisputeSummaryWindow](https://github.com/bisq-network/bisq/blob/df6812a4c958553cfaf4587bf814de9d11be1a87/desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java#L645)
> 

True - I forgot about those two. I even wrote one of it 😬 

As I also agree that it is more readable the way you refactored it and we've already broken this un-outspoken rule, I'll utACK this PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3617#issuecomment-555492132
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191119/65f10596/attachment.html>


More information about the bisq-github mailing list