[bisq-network/bisq] Hash of ProtectedStoragePayload is non-deterministic (leading to duplication of elements in P2PDataStorage) (#3367)

[Justin Carter]

I witnessed the incoming OfferPayloads that were being consumed from my rust project generating different hashes. I have not investigated wether the issue is the byte order that the messages were received with (meaning that they are different coming from different java clients) or the re-serialization (for hashing) within rust.
Regardless Java std lib also doesn't garuantee ordering in its HashMap implementation and is likely to change from version to version or depend on which OS / JVM implementation its being run. So even without direct evidence its prudent to assume this could happen in a java only world as well.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3367#issuecomment-538826973
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191006/b020f7f9/attachment.html>