[bisq-network/bisq] Hash of ProtectedStoragePayload is non-deterministic (leading to duplication of elements in P2PDataStorage) (#3367)

Christoph Sturm notifications at github.com
Mon Oct 7 12:55:33 UTC 2019

from the gist that you linked to:
"While I doubt that any official Google implementation would ever change the serialization, third party implementations may do whatever they like"

I guess the gist of the problem is that we are using protobuf for something that its not intended for.  maybe we can create our own way of hashing the protobuf objects. how would we maintain backward compatibility if we change the hashing? maybe if what the java library does now is stable we can create our own hashing that creates the same hashes. @chimp1984 wdyt?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191007/dfcce3d1/attachment.html>

More information about the bisq-github mailing list