[bisq-network/bisq] periodical UpdateDataReq for Seednodes (#3202)

chimp1984 notifications at github.com
Mon Sep 9 09:17:21 UTC 2019


chimp1984 commented on this pull request.



> @@ -208,7 +208,7 @@ else if (networkEnvelope instanceof RemoveDataMessage)
                     final Set<ProtectedStorageEntry> dataSet = getDataResponse.getDataSet();
                     Set<PersistableNetworkPayload> persistableNetworkPayloadSet = getDataResponse.getPersistableNetworkPayloadSet();
 
-                    if (log.isDebugEnabled()) logContents(networkEnvelope, dataSet, persistableNetworkPayloadSet);
+                    if (log.isInfoEnabled()) logContents(networkEnvelope, dataSet, persistableNetworkPayloadSet);

When I look into logs thets one of the most important info. There i see ig seeds deliver smae numbers, if i got the arbitrators and filters etc. 

> Secondly, if you enable "DEBUG log verbosity" (I assume that is what you meant), INFO is enabled as well. 

Ah ok. did not know that. But yes makes sense  ;-)

> The logging behavior does not change, only the block of undocumented logging code is moved out of the way so one can see the functional code faster.

Yes moving it out in a method is fine.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3202#discussion_r322139940
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190909/60860526/attachment.html>


More information about the bisq-github mailing list