[bisq-network/bisq] Integrate PhoneNumberValidator into HalCashForm (#3236)
Stan
notifications at github.com
Tue Sep 10 15:16:35 UTC 2019
Added country selector to HalCashForm, requiring the following changes.
1. A new CountryUtil method getAllHalCashCountries, returns [ES, PL].
2. HalCashValidator now extends PhoneNumberValidator.
3. HalCashAccountPayload now extends CountryBasedPaymentAccountPayload.
4. HalCashAccount now extends CountryBasedPaymentAccount.
5. Added two new fields to pb.proto.
a. HalCashAccountPayload hal_cash_account_payload field to
CountryBasedPaymentAccountPayload message.
b. accepted_country_codes field to HalCashAccountPayload message.
Note: pb.proto changes may break backward compatibility.
6. Reformatted all modified source files except pb.proto.
This patch is part of solution to Issue #3042.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/3236
-- Commit Summary --
* Integrate PhoneNumberValidator into HalCashForm
-- File Changes --
M common/src/main/proto/pb.proto (2)
M core/src/main/java/bisq/core/locale/CountryUtil.java (8)
M core/src/main/java/bisq/core/payment/HalCashAccount.java (23)
M core/src/main/java/bisq/core/payment/payload/HalCashAccountPayload.java (58)
M desktop/src/main/java/bisq/desktop/components/paymentmethods/HalCashForm.java (98)
M desktop/src/main/java/bisq/desktop/util/validation/HalCashValidator.java (5)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/3236.patch
https://github.com/bisq-network/bisq/pull/3236.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3236
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190910/1952d1ad/attachment.html>
More information about the bisq-github
mailing list