[bisq-network/bisq] Integrate PhoneNumberValidator into HalCashForm (#3236)

Christoph Atteneder notifications at github.com
Thu Sep 19 16:09:04 UTC 2019


ripcurlx requested changes on this pull request.

NACK - I think it is not a good idea to add the account creation validation and push it as far to invalidate all existing HalCash accounts for offers created with phone number validated HalCash accounts. Doing it like that it would also force people with correct phone numbers to create a new account and loose their account age. I think it is better for this PR only to add the phone number validation in the account creation form and leave everything else as is. 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3236#pullrequestreview-290680969
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190919/552c34f9/attachment.html>


More information about the bisq-github mailing list