[bisq-network/bisq] Remove PersistableNetworkPayloadList & TradeStatisticsList (#4159)

Steven Barclay notifications at github.com
Sat Apr 11 10:22:07 UTC 2020

- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".

This is another refactoring PR to continue from the work in #4025, by removing `PersistableNetworkPayloadList` as suggested in the review. This together with #4102 removes all the remaining unnecessary `PersistableEnvelope` implementations.

This class is dead code, together with its store service, as they were only referenced from `CorePersistenceProtoResolver::fromProto`, the binding logic and from `AppendOnlyDataStoreService` by orphaned migration code. However, migration from the old persisted data was completed long ago and the store file is no longer being read or written from anywhere in the codebase.

Also remove its associated `PersistableEnvelope` proto message type, along with the `TradeStatisticsList` message type. The latter is long deprecated and has no corresponding Java class implementing `PersistableEnvelope`, so removing it won't change behaviour (outside the exception message thrown when attempting to resolve it).

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * Remove PersistableNetworkPayloadList & TradeStatisticsList

-- File Changes --

    M core/src/main/java/bisq/core/proto/persistable/CorePersistenceProtoResolver.java (5)
    M p2p/src/main/java/bisq/network/p2p/P2PModule.java (2)
    M p2p/src/main/java/bisq/network/p2p/storage/persistence/AppendOnlyDataStoreService.java (22)
    D p2p/src/main/java/bisq/network/p2p/storage/persistence/PersistableNetworkPayloadList.java (86)
    D p2p/src/main/java/bisq/network/p2p/storage/persistence/PersistableNetworkPayloadListService.java (126)
    M p2p/src/test/java/bisq/network/p2p/storage/mocks/AppendOnlyDataStoreServiceFake.java (1)
    M proto/src/main/proto/pb.proto (17)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200411/51ebb98c/attachment-0001.html>

More information about the bisq-github mailing list