[bisq-network/bisq] [WIP] Autoconfirm XMR trade if tx check was validated by proof service (using tx private key) (#4378)

[chimp1984]

> @chimp1984 How does this look for settings? (GUI & protobuf representation)
> 
> ![image](https://user-images.githubusercontent.com/47253594/89738023-08930580-da3b-11ea-8327-550d1b9df511.png)
> 
> ```
> ///////////////////////////////////////////////////////////////////////////////////////////
> // Preferences
> ///////////////////////////////////////////////////////////////////////////////////////////
> 
> message PreferencesPayload {
> [...]
>     repeated AutoConfirmSettings auto_confirm_settings = 56;
> }
> 
> 
> message AutoConfirmSettings {
>     TradeCurrency coin = 1;
>     bool enabled = 2;
>     int32 nConfirmBlocks = 3;
>     int32 nServicesMustConfirm = 4;
>     int64 amountMaxLimit = 5;
>     int64 amountUsed = 6;
>     repeated string serviceUrl = 7;
> }
> ```

Thanks for the info.

This is quite more advances as I had in mind. I guess that will require a small sub UI to not blow up the settings too much. Maybe an new tab? Specially if its designed for extending to other altcoins. The coin selection would create new setting entries for each coin. It would have a similar structure like the account UI (list of entries with details view on selection and create/delete buttons).

The amountUsed and reset button are not totally clear to me. Reset that currently used amount? But what time interval or is it counting up and reset is only way to clear it? Then its a bit annoying as user need to maintain that manually...
Maybe its enough to set a limit per trade (e.g. only auto confirm for trades < 1 BTC).

Regaring other altcoins:
With other altcoins its a block explorer look up but we have a small open problem there: How do identify a tx in case of 2 trades with exactly the same trade amount? The BTC buyer has to send the TX ID but as he knows the receiver address he could look up and if he finds a recent tx he could use that one, and then the seller does not know which one has paid. With manual payout its not a big deal as he can simply wait until both are transferred or ask via the chat both traders. With auto confirm though that could lead to the wrong BTC payout.  
I guess there is no easy solution but as it is a rare edge case I would suggest to deactivate the autoconfirm in case the user has multiple trades with same altcoin amounts. 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4378#issuecomment-672565771
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200811/27bd7b10/attachment.html>