[bisq-network/bisq] Autoconfirm XMR trade if tx check was validated by proof service (#4421)

[James Cox]

Hi @chimp1984 thank you for taking time to review again.  

> Clearnet handling of provider for non-tor dev setup is missing.

Clearnet in dev mode is by default - no special handling needed.  The SOCKS5 proxy provider is null in dev mode so HttpClient uses clearnet.  To attest to that I've been using emzy's clearnet service for the past few weeks.  The relevant line in HttpClient:
https://github.com/bisq-network/bisq/blob/f45a26ca54b8fcecdc8b071f0f1eca7d042cb4c4/p2p/src/main/java/bisq/network/http/HttpClient.java#L97-L100

If I have misunderstood please correct me.  

I am working on all other points you brought up.  Then I'll merge in latest from master as requested (after squashing my commits).

Cheers.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4421#issuecomment-681092085
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200826/1c0524a0/attachment.html>