[bisq-network/bisq] Add local Bitcoin node configuration detection (#3982)

[dmos62]

dmos62 commented on this pull request.



> @@ -559,7 +576,7 @@ else if (displayTorNetworkSettingsHandler != null)
 
         // We only init wallet service here if not using Tor for bitcoinj.
         // When using Tor, wallet init must be deferred until Tor is ready.
-        if (!preferences.getUseTorForBitcoinJ() || localBitcoinNode.isDetected()) {

You're right, I missed that. My concern here is that this line decides whether to "initiate wallet" at this time, which implies that Tor will not be used. I think ideally `Preferences.getUseTorForBitcoinJ()` would be a full authority on whether or not we're using Tor, but here it's only one half of the condition.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3982#discussion_r384473102
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200226/c6a414bc/attachment.html>