[bisq-network/bisq] Display minimum limit if used during trade (#3870)

Christoph Atteneder notifications at github.com
Tue Jan 7 16:35:36 UTC 2020

In the past we didn't give the user a hint if the minimum trading fee or minimum deposit was used.
It was shown to the user during offer creation and gave especially new users the impression
that Bisq has very high trading fees and requires a crazy amount for deposit in relation to the trading amount.

Fixes #3868, #3746.
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * Use trading fee in BSQ fee comparison
  * Add information if minimum trading fee or minimum security deposit is used
  * Show minimum security deposit in create offer dialog when used

-- File Changes --

    M core/src/main/resources/i18n/displayStrings.properties (7)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java (4)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferView.java (22)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java (26)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferViewModel.java (14)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java (23)
    M desktop/src/main/java/bisq/desktop/util/GUIUtil.java (12)
    M desktop/src/test/java/bisq/desktop/util/GUIUtilTest.java (36)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200107/982a74e4/attachment.html>

More information about the bisq-github mailing list