[bisq-network/bisq] Refactor option handling (#3889)

Chris Beams notifications at github.com
Mon Jan 20 10:25:24 UTC 2020

cbeams commented on this pull request.

> +        'io.opencensus:opencensus-api:8e2cb0f6391d8eb0a1bcd01e7748883f0033b1941754f4ed3f19d2c3e4276fc8',
+        'io.opencensus:opencensus-contrib-grpc-metrics:29fc79401082301542cab89d7054d2f0825f184492654c950020553ef4ff0ef8',
+        'io.opencensus:opencensus-contrib-http-util:d62fd27175a842bde135f6f6b1d6f25d42e9bd59a87bc98709a4760fe399ee14',
+        'io.perfmark:perfmark-api:b734ba2149712409a44eabdb799f64768578fee0defe1418bb108fe32ea43e1a',

Good catch. Some of these and a number of other dependencies are removed in [a commit that currently exists only in my fork's grpc-api branch](https://github.com/cbeams/bisq/commit/85781a23d0abcba169ec8aa7d6d409741c0ac5df). These changes were made as part of further refactorings of @chimp1984's original PoC, and it was an oversight that I didn't include them here. It will require some rework of that commit to do so, but is probably worth it to make sure we don't ship a release that includes these deps, even if they will be removed soon thereafter. I'll push that additional commit as soon as possible. Though note that I'll probably push it against the `grpc-poc` branch (PR #3888), as it's really part of that change as opposed to this one.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200120/b30bbd30/attachment.html>

More information about the bisq-github mailing list