[bisq-network/bisq] Refactor option handling (#3889)
notifications at github.com
Mon Jan 20 11:28:41 UTC 2020
> @ripcurlx re: [#3889 (review)](https://github.com/bisq-network/bisq/pull/3889#pullrequestreview-345220708), this is also regarding #3888. To be clear, can you re-iterate that your ACK is for the changes specific to this PR, i.e. all things `Config` and related to option handling?
Actually for both - So I read through all the changes regarding `Config` changes and it worked for my local setup. Regarding the remarks in #3888: I didn't run the code before, just reviewed the changes, so I checked this time the GRPC prototype in my local setup as well.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the bisq-github