[bisq-network/bisq] Add rpc method 'createpaymentacct' (#4308)

[dmos62]

@dmos62 commented on this pull request.



> +                    out.println(reply.getFundingAddressesInfo());
+                    return;
+                }
+                case createpaymentacct: {
+                    if (nonOptionArgs.size() < 2)
+                        throw new IllegalArgumentException("no account name specified");
+
+                    var accountName = nonOptionArgs.get(1);
+
+                    if (nonOptionArgs.size() < 3)
+                        throw new IllegalArgumentException("no account number specified");
+
+                    var accountNumber = nonOptionArgs.get(2);
+
+                    if (nonOptionArgs.size() < 4)
+                        throw new IllegalArgumentException("no fiat currency specified");

These size-based checks don't actually know if it was the last argument that was ommitted. We might (or might not) go for more interesting interfaces in the future, but in this case we only know that not all arguments were passed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4308#pullrequestreview-435052357
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200622/701ce72d/attachment.html>