[bisq-network/bisq] Prevent dust outputs from being created during the trade process (#4094)

[James Cox]

This change fixes an issue whereby dust change outputs are inadvertently created during the trading process, unbeknownst to the user.  The dust outputs cause the Bitcoin node to reject the
transaction and the trade then becomes stuck.

The solution taken here is to detect a dust TXO during the trade process and remove it from the transaction before broadcasting.  This applies in both making an offer and/or taking an existing offer.  When a dust output is prevented, it will be noted in the log as follows:

![image](https://user-images.githubusercontent.com/47253594/77453644-82e12700-6dc5-11ea-83cf-eb2227c6275d.png)


Related to #4039




You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4094

-- Commit Summary --

  * Remove dust outputs created during the trade process

-- File Changes --

    M core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java (24)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4094.patch
https://github.com/bisq-network/bisq/pull/4094.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4094
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200324/50fd6cdc/attachment.html>