[bisq-network/bisq] Add holder name for new Faster Payments accounts (#4046)

Christoph Atteneder notifications at github.com
Thu Mar 26 15:28:25 UTC 2020

@ripcurlx requested changes on this pull request.

NACK - please see my comment regarding the buyers UI during the trade process.
Also please only commit changes to the English source file all other files will be overwritten automatically by loading translations from Transifex before the next release.

ACK from a functionality perspective. Tested old and new Faster Payment Accounts in trades.

> +        if (!((FasterPaymentsAccountPayload) paymentAccountPayload).getHolderName().isEmpty()) {
+            addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("payment.account.owner"),
+                    ((FasterPaymentsAccountPayload) paymentAccountPayload).getHolderName());
+        }

If this field is shown during the trade process it creates unnecessary scrolling.
<img width="1312" alt="Bildschirmfoto 2020-03-26 um 16 16 33" src="https://user-images.githubusercontent.com/170962/77663881-d8603400-6f7d-11ea-918c-ed11a5557106.png">
I'd just change line 54-55 to
addCompactTopLabelTextField(gridPane, gridRow, 1, Res.get("payment.accountNr"),
                ((FasterPaymentsAccountPayload) paymentAccountPayload).getAccountNr());
which puts sort code and account nr next to each other.
<img width="1312" alt="Bildschirmfoto 2020-03-26 um 16 19 57" src="https://user-images.githubusercontent.com/170962/77663992-ff1e6a80-6f7d-11ea-8847-11f72f189964.png">
That would work for both cases.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200326/782705fb/attachment.html>

More information about the bisq-github mailing list