[bisq-network/bisq] Display "Payment Method" column in Open Offers view (#4193)

James Cox notifications at github.com
Thu May 14 15:07:12 UTC 2020

@jmacxx commented on this pull request.

> @@ -116,6 +118,10 @@ public void initialize() {
         priceColumn.setComparator(Comparator.comparing(o -> o.getOffer().getPrice(), Comparator.nullsFirst(Comparator.naturalOrder())));
         volumeColumn.setComparator(Comparator.comparing(o -> o.getOffer().getVolume(), Comparator.nullsFirst(Comparator.naturalOrder())));
         dateColumn.setComparator(Comparator.comparing(o -> o.getOffer().getDate()));
+        paymentMethodColumn.setComparator(Comparator.comparing(
+                o -> o.getOffer() != null ? o.getOffer().getPaymentMethod().getId() : null,

I agree, and will modify to bring it into line with the code above it.

Just to note, this line was copied from the existing PendingTradesView.java in which there is a payment method column.  Should I also make a change to do the same in PendingTradesView.java or would that need to be a separate code-cleanup type PR?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200514/7379df87/attachment.html>

More information about the bisq-github mailing list