[bisq-network/bisq] Trade protocol domain improvements (#4566)

[chimp1984]

@chimp1984 commented on this pull request.



> +        Stream<AddressEntry> availableAndPayout = Stream.concat(getAddressEntries(AddressEntry.Context.TRADE_PAYOUT)
+                .stream(), getFundedAvailableAddressEntries().stream());
+        Stream<AddressEntry> available = Stream.concat(availableAndPayout,
+                getAddressEntries(AddressEntry.Context.ARBITRATOR).stream());

AVAILABLE is if it has no role in the trade. Spendable would not cover that correctly as TRADE_PAYOUT is spendable as well. But better NOT_USED_IN_TRADE would be prob. more clear.  But as AddressEntry is a protobuf field I prefer to not change anything if not needed (though I guess rename would be ok).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4566#discussion_r496280703
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200928/adc63466/attachment-0001.html>