[bisq-network/bisq] Trade protocol domain improvements (#4566)

chimp1984 notifications at github.com
Mon Sep 28 23:00:04 UTC 2020


@chimp1984 commented on this pull request.



> +        Stream<AddressEntry> availableAndPayout = Stream.concat(getAddressEntries(AddressEntry.Context.TRADE_PAYOUT)
+                .stream(), getFundedAvailableAddressEntries().stream());
+        Stream<AddressEntry> available = Stream.concat(availableAndPayout,
+                getAddressEntries(AddressEntry.Context.ARBITRATOR).stream());

Yes these stream concatenations are not nice. Its old code just moved from Trademanager, did not want to change too much... But to do a custom filter would be probably more clear here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4566#discussion_r496281086
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200928/f8711bcc/attachment.html>


More information about the bisq-github mailing list