[bisq-network/bisq] API BSQ swap simulation script and doc updates #5 (PR #5876)

[Christoph Atteneder]

> > After a couple of seconds I tried to request [_MY_] offer with:
> > ```
> > ./bisq-cli --password=xyz getoffer --offer-id=1376837-1edf81cf-49bb-4a88-97cd-143bcf850025-175
> > ```
> > 
> > 
> >     
> >       
> >     
> > 
> >       
> >     
> > 
> >     
> >   
> > which failed with
> > ```
> > Error: offer with id '1376837-1edf81cf-49bb-4a88-97cd-143bcf850025-175' not found
> > ```
> > 
> > 
> >     
> >       
> >     
> > 
> >       
> >     
> > 
> >     
> >   
> > Requesting all offers with:
> > ```
> > ./bisq-cli --password=xyz getmyoffers --direction=BUY --currency-code=BSQ                     
> > ```
> > 
> > 
> >     
> >       
> >     
> > 
> >       
> >     
> > 
> >     
> >   
> > did succeed.
> 
> If you want to request your own offer, you need to use the `getmyoffer` command, not `getoffer` command, which looks for available offers created by other users.
> 
> This should have worked, and did for me while trying to reproduce the problem: `./bisq-cli --password=xyz getmyoffer --offer-id=1376837-1edf81cf-49bb-4a88-97cd-143bcf850025-175`
> 
> And you saw that requesting `my` offers (plural) did work as expected: `./bisq-cli --password=xyz getmyoffers --direction=BUY --currency-code=BSQ` Calling `getoffers` (available offers) would not have worked.

I forgot about our separation of getoffers, getoffer and getmyoffers, getmyoffer. Still I'm not sure if we really need the getmyoffer endpoint and not just use the getoffer endpoint. As you pass the offer id I would always expect to get the offer no matter if it was my offer or someone else offer. There is no auto filtering taking place as for all the other methods. WDYT?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5876#issuecomment-985994668
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211204/65182c47/attachment.htm>