[bisq-network/bisq] API BSQ swap simulation script and doc updates #5 (PR #5876)

Stan notifications at github.com
Sat Dec 4 15:47:37 CET 2021


> I'm not sure if we really need the getmyoffer endpoint and not just use the getoffer endpoint. As you pass the offer id I would always expect to get the offer no matter if it was my offer or someone else offer. There is no auto filtering taking place as for all the other methods. WDYT?

I agree.  Is it OK if I make the change

- deprecate `getmyoffer`
- make `getoffer` return the offer regardless of ownership

in a new PR, on top of the last & next PR in this chain, ending in  https://github.com/bisq-network/bisq/pull/5893?
The change request seems to deserve it's own PR, and that would let me work on top of the #5893 changes for XMR support.

And finally, to be clear about the scope of the requested change:  API endpoints `getmyoffers` and `getoffers` will remain as is.  Is that right?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5876#issuecomment-986039273
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211204/b1a3031b/attachment.htm>


More information about the bisq-github mailing list