[bisq-network/bisq] Clean tor directory at startup (PR #5903)

[chimp1984]

This PR is an intent to fight the messaging issues. We had in the past sometimes issues that Tor became instable and deleting the tor directory (excluding the hidden service dir) solved that. So it might be worth to see if it helps if we reset at each startup the tor directory. 
The startup time for Tor is a bit slower as it need to download about 10MB of data. 

Tests showed that it takes about 8 seconds longer. On a slow internet connection its about  15-25 sec slower.

I dont have a very strong opinion if we should use that PR as the chances that it fixes the problem are not super high, but its a relatively cheap attempt which comes with only a small delay at startup. Give a thumbs up/down if you support that PR.
I researched also to find if there are reported bugs with corrupted/outdated tor data but could not find much beside that at shutdown the decriptor files might get corrupted, but I assume that would lead to problems as starting Tor.

Normal:
```
bisq.log:Tor started after 6736 ms. Start publishing hidden service.
bisq.log:Tor started after 6182 ms. Start publishing hidden service.
bisq.log:Tor started after 5802 ms. Start publishing hidden service.
bisq.log:Tor started after 6286 ms. Start publishing hidden service.
bisq.log:Tor started after 6303 ms. Start publishing hidden service.
```

With that PR:
```
bisq.log:Tor started after 14819 ms. Start publishing hidden service.
bisq.log:Tor started after 13833 ms. Start publishing hidden service.
bisq.log:Tor started after 12840 ms. Start publishing hidden service.
bisq.log:Tor started after 13760 ms. Start publishing hidden service.
```
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5903

-- Commit Summary --

  * Clean tor directory at startup

-- File Changes --

    M core/src/main/java/bisq/core/app/BisqSetup.java (14)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5903.patch
https://github.com/bisq-network/bisq/pull/5903.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5903
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211207/108a6488/attachment.htm>