[bisq-network/bisq] Apply Localized Number Formatting To Transaction Details (PR #5902)

[Christoph Atteneder]

@ripcurlx requested changes on this pull request.

NACK - There are a couple of issues that need to get addressed.

If we localize the BSQ formatting it also needs to be done in one go for the other number formatting as well. Otherwise we end in situations like in this screenshot:
<img width="1259" alt="Bildschirmfoto 2021-12-20 um 11 27 11" src="https://user-images.githubusercontent.com/170962/146752850-8dd82d38-b3dd-4680-91c5-1aa6d4b20bed.png">

I also found an exception when clicking around on the Mainnet app when entering `Facts & Figures > BSQ Supply`.
```
java.lang.NumberFormatException: For input string: "0,00"
	at java.base/jdk.internal.math.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:2054)
	at java.base/jdk.internal.math.FloatingDecimal.parseDouble(FloatingDecimal.java:110)
	at java.base/java.lang.Double.parseDouble(Double.java:549)
	at bisq.desktop.main.dao.economy.supply.dao.DaoChartViewModel$1.toString(DaoChartViewModel.java:91)
	at bisq.desktop.main.dao.economy.supply.dao.DaoChartViewModel$1.toString(DaoChartViewModel.java:88)
	at javafx.scene.chart.NumberAxis.measureTickMarkSize(NumberAxis.java:334)
```

 I haven't tried it out yet, but I think it is also good to try out a regular BSQ trade (Altcoin or Altcoin instant) to see if the amount copy & pasting also doesn't have any issues with the new formatting.




-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5902#pullrequestreview-836231781
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5902/review/836231781 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211220/6eee3623/attachment.htm>