[bisq-network/bisq] Implement Segwit for BSQ (#5000)

Steven Barclay notifications at github.com
Thu Jan 21 10:30:15 CET 2021


@stejbac commented on this pull request.



> +
+import java.util.List;
+
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+
+ at Data
+ at NoArgsConstructor
+ at JsonInclude(JsonInclude.Include.NON_NULL)
+ at JsonIgnoreProperties(ignoreUnknown = true, value = "ntx")
+ at JsonPropertyOrder({"hash", "confirmations", "strippedsize", "size", "weight", "height", "version", "versionHex",
+        "merkleroot", "tx", "time", "mediantime", "nonce", "bits", "difficulty", "chainwork", "nTx",
+        "previousblockhash", "nextblockhash"})
+public class RawBlock {

I just took the names from the very similar DTO classes defined in the original btcd-cli4j library. Perhaps I could rename them from `Raw...` to `DtoBlock`, `DtoTransaction`, etc.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5000#discussion_r561723650
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210121/137dc293/attachment.htm>


More information about the bisq-github mailing list