[bisq-network/bisq] Fix bug in chat message status display (#5599)
jmacxx
notifications at github.com
Fri Jul 2 16:09:46 CEST 2021
Reported by @huey735 there is a display bug when chat messages are stored in mailbox awaiting peer to come online.
The bug was introduced by #5551
The fix is to consider both acknowledged and stored in mailbox statuses when checking if the message timed out.
To reproduce:
- Alice sends chat message to Bob (who is offline).
- Alice's chat window shows `Message saved in receiver's mailbox`.
- Alice closes chat window, and reopens it again.
- Alice's chat window now says `Error: timed out. Try sending message again`. << This is the bug.
Expected behavior:
- Alice sends chat message to Bob (who is offline).
- Alice's chat window shows `Message saved in receiver's mailbox`.
- Alice closes chat window, and reopens it again.
- Alice's chat window shows `Message saved in receiver's mailbox`.
If Bob were to come online Alice's window would update to `Message arrival confirmed by receiver`.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/5599
-- Commit Summary --
* fix bug in chatmessage timeout status
-- File Changes --
M core/src/main/java/bisq/core/support/messages/ChatMessage.java (2)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/5599.patch
https://github.com/bisq-network/bisq/pull/5599.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5599
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210702/c1afdad2/attachment-0001.htm>
More information about the bisq-github
mailing list