[bisq-network/bisq] Fix incorrect tx link to tx explorer - fixes #5548 (#5563)

Christoph Atteneder notifications at github.com
Thu Jun 17 15:53:34 CEST 2021


@ripcurlx commented on this pull request.



> +    public static void setPreferences(Preferences preferences) {
+        ExplorerAddressTextField.preferences = preferences;
+    }

> `preferences` is static field, not sure why - I used same approach like in `TxIdTextField`

Yes it is true that it is right now the same as in TxIdTextField, but I also would prefer using the @Setter annotation and getting rid of the unnecessary setPreferences method.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5563#discussion_r653587352
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210617/729f6021/attachment-0001.htm>


More information about the bisq-github mailing list