[bisq-network/bisq] Improve TradeStatistics validation (PR #5853)

[Stan]

@ghubstan commented on this pull request.



> @@ -443,7 +443,8 @@ public boolean isValid() {
             if (optionalPaymentMethodById.isPresent()) {
                 maxTradeLimit = optionalPaymentMethodById.get().getMaxTradeLimitAsCoin(currency).value;
             }
-        } catch (Exception ignore) {
+        } catch (Exception e) {
+            log.warn("Error at isValid(). " + e.toString(), e);

I'm prettry sure `e.toString(),  e` will result in a duplicated stack trace in the log.   Maybe `log.warn("Error at isValid(). {}", e);` is enough?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5853#pullrequestreview-813165785
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211122/025992e2/attachment.htm>