[bisq-network/bisq] Improve TradeStatistics validation (PR #5853)

Christoph Atteneder notifications at github.com
Tue Nov 23 09:44:21 CET 2021


@ripcurlx commented on this pull request.



> @@ -443,7 +443,8 @@ public boolean isValid() {
             if (optionalPaymentMethodById.isPresent()) {
                 maxTradeLimit = optionalPaymentMethodById.get().getMaxTradeLimitAsCoin(currency).value;
             }
-        } catch (Exception ignore) {
+        } catch (Exception e) {
+            log.warn("Error at isValid(). " + e.toString(), e);

I think so too. The first object that is passed is called `.toString` upon. I'll push a fix to this branch.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5853#discussion_r754898374
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211123/a34046ec/attachment.htm>


More information about the bisq-github mailing list