[bisq-network/bisq] Add "Buy BSQ" button next to trade fee selector (#5055)

Christoph Atteneder notifications at github.com
Wed Oct 13 11:47:35 CEST 2021


The current process is now as follows for no-BSQ-coiner.
Someone wants to buy BTC via Revolut
![Bildschirmfoto 2021-10-13 um 11 24 31](https://user-images.githubusercontent.com/170962/137107473-30235bdd-ceb7-41dd-adc5-d88568be0273.png)
She decides she want to save money and support the project and clicks on Buy BSQ
![Bildschirmfoto 2021-10-13 um 11 24 37](https://user-images.githubusercontent.com/170962/137107648-dd3d4a88-2603-4812-bb4f-75a787b11ef3.png)
She clicks on `Take offer to buy BSQ`
![Bildschirmfoto 2021-10-13 um 11 30 08](https://user-images.githubusercontent.com/170962/137107778-a3c89b16-6987-4f15-a141-c2b390a084d6.png)
She clicks on `Create Account` (Account is created and the offer is taken and opens the take offer screen). Probably it should be named `Create Account and Take Offer`. Also there shouldn't be a `Buy BSQ` hint when the user tries to buy BSQ.
She proceeds with purchasing BSQ
![Bildschirmfoto 2021-10-13 um 11 30 23](https://user-images.githubusercontent.com/170962/137107864-3aed24db-7e6b-4f8c-a5c7-fa4961c030fc.png)
When needing to confirm the BSQ transfer there is now the `Show Payment in BSQ Wallet` Button to open the BSQ wallet. Further optimization is not necessary as BSQ <>BTC atomic swap offers will be available soon.
![Bildschirmfoto 2021-10-13 um 11 32 06](https://user-images.githubusercontent.com/170962/137108584-366083d2-969b-4919-80a5-1917a1ded3e4.png)
![Bildschirmfoto 2021-10-13 um 11 32 36](https://user-images.githubusercontent.com/170962/137108854-d864b3f0-14ed-4865-b61e-bb8bf3fd7e03.png)
After completing the trade she can select BSQ in the offer creation process. (ATM the BSQ Button is not gone as it is not updated live)
![Bildschirmfoto 2021-10-13 um 11 32 51](https://user-images.githubusercontent.com/170962/137108916-ca1ab91f-b6c3-449e-8f4a-08ae330c051d.png)

@pazza83 @Conza88 

so IMO following points are still open to make this PR mergable:

- [ ] Don't show `Buy BSQ` hint when trying to buy BSQ.
- [ ] BSQ Button has to be updated live (on view activation) so it is not displayed anymore after successful BSQ purchase
- [ ] The Combobox UI glitch mentioned in https://github.com/bisq-network/bisq/pull/5055#issuecomment-931183094



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-942122870
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211013/c858ad07/attachment-0001.htm>


More information about the bisq-github mailing list