[bisq-network/bisq] Some BTC addresses utilized by Bisq are receiving both trade fees and time-locked deposits (Issue #5762)

[pazza]

<!--
   SUPPORT REQUESTS: This is for reporting bugs in the Bisq app.
   If you have a support request, please join #support on Bisq's
   Keybase team over at https://keybase.io/team/Bisq
-->

### Description

Following discussion on Running the numbers of the Bisq DAO https://github.com/bisq-network/bisq/discussions/5171 and the subsequent discussions with other contributors a recent Bisq call. I thought it would be beneficial to open a separate issue to discuss the fact the some BTC addresses utilized by Bisq are receiving both trade fees and time-locked deposits.

Bisq utilizes BTC addresses to receive trade fees (for users not paying in BSQ) and to receive delayed payouts (time-locked deposits to a donation address) when either trader decides to send funds to arbitration. 

The addresses in current use can be seen here in a comment by @chimp1984 https://github.com/bisq-network/bisq/discussions/5171#discussioncomment-372304

Ideally, from an accounting / auditing perspective, Bisq would have addresses that only received either trade fees OR delayed payouts.

The issue with addresses receiving both trade fees AND delayed payouts is that it makes accounting / auditing more difficult.

### Version

1.7.4

### Steps to reproduce

Looking at all the addresses used by Bisq to receive trade fees and delayed payouts I compiled the following table. It appears that most addresses used by Bisq for this purpose receive both trade fees and time-locked deposits. 

| Address | Notes | Receiving trade fees | Receiving time-locked deposits | Last Active / Comments |
| ------------- | ------------- | ------------- | ------------- | ------------- |
| [1BVxNn3T12veSK6DgqwU4Hdn7QHcDDRag7](https://mempool.space/address/1BVxNn3T12veSK6DgqwU4Hdn7QHcDDRag7) | Default donation address  | Yes  | Yes  | April 2021, nit sure if this address has now been retired? |
| [3EtUWqsGThPtjwUczw27YCo6EWvQdaPUyp](https://mempool.space/address/3EtUWqsGThPtjwUczw27YCo6EWvQdaPUyp)  | burning2019 | Yes  | Yes | August 2021 - Sporadic use, not sure if due to people running old versions of Bisq? |
| [3A8Zc1XioE2HRzYfbb5P8iemCS72M6vRJV](https://mempool.space/address/3A8Zc1XioE2HRzYfbb5P8iemCS72M6vRJV)  | burningman2 | Yes | Yes | August 2021 - Sporadic use, not sure if due to people running old versions of Bisq? |
| [38bZBj5peYS3Husdz7AH3gEUiUbYRD951t](https://mempool.space/address/38bZBj5peYS3Husdz7AH3gEUiUbYRD951t)  | burningman3 | Yes | No | In constant use - I assume this is the main address for BTC trade fees. It is only receiving trade fees so this is good |
| [34VLFgtFKAtwTdZ5rengTT2g2zC99sWQLC](https://mempool.space/address/34VLFgtFKAtwTdZ5rengTT2g2zC99sWQLC)  | burningman3 | Yes | Yes | In constant use -  Mainly used as a donation address. Not sure why it is still receiving sporadic trade fees? |

### Expected behaviour

If possible the following addresses to be retired:

- 1BVxNn3T12veSK6DgqwU4Hdn7QHcDDRag7
- 3EtUWqsGThPtjwUczw27YCo6EWvQdaPUyp
- 3A8Zc1XioE2HRzYfbb5P8iemCS72M6vRJV

If possible the following address to receive no trade fees:

- 34VLFgtFKAtwTdZ5rengTT2g2zC99sWQLC

#### Additional info

If the above can be achieved would it be possible have a script or similar that could calculate:

- Trade fees received per month to 38bZBj5peYS3Husdz7AH3gEUiUbYRD951t
- Time locked deposit amounts sent to 34VLFgtFKAtwTdZ5rengTT2g2zC99sWQLC

Ideally the above would be included in the DAO charts:

![dao](https://user-images.githubusercontent.com/66367547/137670136-e1cabcde-9896-4a58-8f79-66dd729fc9a7.PNG)

Failing the above a script or something similar to differentiate total trade fees vs total delayed payouts per calendar month, cycle, or year would be a useful tool for accounting / auditing. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5762
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/e22e1161/attachment-0001.htm>