[bisq-network/bisq] Some BTC addresses utilized by Bisq are receiving both trade fees and time-locked deposits (Issue #5762)

[chimp1984]

The Default donation address is used by people who have deactivated the DAO.

The old addresses are likely used because of out of sync DAO state. Really old Bisq nodes cannot be used for trading as there is an requirement for newer versions by the newer trade protocol.
We could detect if one of the old addresses are used and then enforce a DAO resync, this should clean up that problem for those who update to that version, so might take also a bit until its effective. Later we could let trades fail if those addresses are still used to enforce that users update, but not sure it that's justified.

I would recommend to ignore in the meantime those values or to include it in the tracking of the main addresses.

I will have a look why 34VLFgtFKAtwTdZ5rengTT2g2zC99sWQLC is receiving the trade fee. This should not be the case, but I guess its also from older versions... I guess we added the dedicated other address later...

In the meantime until a script for monthly reports on 38bZBj5peYS3Husdz7AH3gEUiUbYRD951t and 34VLFgtFKAtwTdZ5rengTT2g2zC99sWQLC are in place, we could just check each start of month manually the total balance received of those addresses and subtract the past balance to get the diff of that month. 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5762#issuecomment-945764146
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/85158ac0/attachment-0001.htm>