[bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
Stan
notifications at github.com
Thu Oct 21 18:19:25 CEST 2021
@ghubstan commented on this pull request.
> private final Preferences preferences;
private final PriceFeedService priceFeedService;
private final ObservableList<ClosedTradableListItem> list = FXCollections.observableArrayList();
private final ListChangeListener<Tradable> tradesListChangeListener;
+ /**
+ * Supplies a List<Tradable> from this JFX ObservableList<ClosedTradableListItem>
+ * collection, for passing to core's ClosedTradeUtil which has no dependency on JFX.
My bad comment: I should not have said anything about what might call this supplier, just remark that it can be used in layers that cannot have any JFX deps.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-785925218
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/b2197b22/attachment.htm>
More information about the bisq-github
mailing list