[bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)

[Stan]

@ghubstan commented on this pull request.



> +package bisq.core.trade.model;
+
+import bisq.core.offer.Offer;
+import bisq.core.trade.protocol.ProtocolModel;
+import bisq.core.trade.protocol.Provider;
+import bisq.core.trade.protocol.TradePeer;
+
+import bisq.network.p2p.NodeAddress;
+
+import bisq.common.taskrunner.Model;
+import bisq.common.util.Utilities;
+
+import javafx.beans.property.ReadOnlyStringProperty;
+import javafx.beans.property.SimpleStringProperty;
+import javafx.beans.property.StringProperty;
+

Since this lives in the core gradle subproject, could it be refactored a bit to get rid of these three imports?
```
import javafx.beans.property.ReadOnlyStringProperty;
import javafx.beans.property.SimpleStringProperty;
import javafx.beans.property.StringProperty;
```
I know they are critical for the bisq desktop app, but in a more modular system (like the misq prototype), they would be excluded from its `core` module, and this `TradeModel` could / would be used in all three higher level modules (grpc, web, jfx) without mixing any user-interface dependencies that one or the other higher level module would not use.  Put another way, the misq `grpc` and `web` modules should not have to include any `javafx` dependency, but it would have to if they wanted to use this class.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-786006518
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/e01f976a/attachment.htm>