[bisq-network/bisq] BSQ swap low risk refactorings [2] (PR #5770)

[Stan]

@ghubstan commented on this pull request.



> +package bisq.core.trade.model;
+
+import bisq.core.offer.Offer;
+import bisq.core.trade.protocol.ProtocolModel;
+import bisq.core.trade.protocol.Provider;
+import bisq.core.trade.protocol.TradePeer;
+
+import bisq.network.p2p.NodeAddress;
+
+import bisq.common.taskrunner.Model;
+import bisq.common.util.Utilities;
+
+import javafx.beans.property.ReadOnlyStringProperty;
+import javafx.beans.property.SimpleStringProperty;
+import javafx.beans.property.StringProperty;
+

The next commit (8cd85a77c148a7d01de9b41d25832ca0af6f334e) reminds me `Trade` is pretty tightly coupled to JFX, it will be quite awhile before we can separate the `core.Trade` entity from JFX, and refactoring `TradeModel` is a less-than-half measure.   So these comments are not really change request, but only a reminder.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#discussion_r733930132
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/e9cae42b/attachment.htm>