[bisq-network/bisq] BSQ swap low risk refactorings [2] (PR #5770)

[chimp1984]

@chimp1984 commented on this pull request.



>      private final Preferences preferences;
     private final PriceFeedService priceFeedService;
     private final ObservableList<ClosedTradableListItem> list = FXCollections.observableArrayList();
     private final ListChangeListener<Tradable> tradesListChangeListener;
 
+    /**
+     * Supplies a List<Tradable> from this JFX ObservableList<ClosedTradableListItem>
+     * collection, for passing to core's ClosedTradeUtil which has no dependency on JFX.

Yes, but I think there are so many dependenceis with Observables and Properties in core that it would be too much effort to try to get rid of it. But for new code if it can be a simple List the better of course.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#discussion_r734031460
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/80abf032/attachment.htm>