[bisq-network/bisq] BSQ swap low risk refactorings [2] (PR #5770)

chimp1984 notifications at github.com
Thu Oct 21 22:44:42 CEST 2021


@chimp1984 commented on this pull request.



> +package bisq.core.trade.model;
+
+import bisq.core.offer.Offer;
+import bisq.core.trade.protocol.ProtocolModel;
+import bisq.core.trade.protocol.Provider;
+import bisq.core.trade.protocol.TradePeer;
+
+import bisq.network.p2p.NodeAddress;
+
+import bisq.common.taskrunner.Model;
+import bisq.common.util.Utilities;
+
+import javafx.beans.property.ReadOnlyStringProperty;
+import javafx.beans.property.SimpleStringProperty;
+import javafx.beans.property.StringProperty;
+

See comment of previous post. In Misq I would start also with no FX dependencies and use diff observer patterns but in Bisq its all over the place already. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#discussion_r734032573
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/87d71151/attachment.htm>


More information about the bisq-github mailing list