[bisq-network/bisq] Add missing filtering on lists (PR #5963)

[xyzmaker123]

@xyzmaker123 commented on this pull request.



>  <VBox fx:id="root" fx:controller="bisq.desktop.main.funds.deposit.DepositView"
       spacing="10" xmlns:fx="http://javafx.com/fxml">
     <padding>
         <Insets bottom="15.0" left="15.0" right="15.0" top="15.0"/>
     </padding>
-
+    <HBox spacing="5.0">

I agree - I'm just not sure if this pull request is appropriate place for doing it. `DepositView` and others similar already have FXML items declared. It's probably not good idea to mix both concepts (adding filtering `HBox` in java code while keeping `TableView` and `GridPane` in fxml). To keep this PR compact and monothematic I prefer to keep it as it is and prepare complex refactoring in dedicated pull request after merging this one.

However I'm a bit curious about performance issue with fxml rendering. I thought that thanks of [CachingViewLoader](https://github.com/bisq-network/bisq/blob/7f73df5dfd761a26392fb6ae16adc937ef6bf9da/desktop/src/main/java/bisq/desktop/common/view/CachingViewLoader.java) usage views are parsed once while loading and later it doesn't affect performance. If you know any resources that could help me to better understand this problem I'd be thankful.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5963#discussion_r789621786
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5963/review/859489231 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220121/4ea4cd68/attachment-0001.htm>