[bisq-network/bisq] Add missing filtering on lists (PR #5963)

[chimp1984]

@chimp1984 commented on this pull request.



>  <VBox fx:id="root" fx:controller="bisq.desktop.main.funds.deposit.DepositView"
       spacing="10" xmlns:fx="http://javafx.com/fxml">
     <padding>
         <Insets bottom="15.0" left="15.0" right="15.0" top="15.0"/>
     </padding>
-
+    <HBox spacing="5.0">

Ok with me.
Re performance: Yes the CachingViewLoader was introduced to avoid the extra costs each time the view is opened. But there is still the penalty for the first time. If you have a very component heavy UI screen in FXML and then in plain Java code you can see/measure the difference. Parsing FXML does not come for free...

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5963#discussion_r789628946
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5963/review/859499604 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220121/714cb9d0/attachment.htm>