[bisq-network/bisq] Add missing filtering on lists (PR #5963)

[xyzmaker123]

@xyzmaker123 commented on this pull request.



>  <VBox fx:id="root" fx:controller="bisq.desktop.main.funds.deposit.DepositView"
       spacing="10" xmlns:fx="http://javafx.com/fxml">
     <padding>
         <Insets bottom="15.0" left="15.0" right="15.0" top="15.0"/>
     </padding>
-
+    <HBox spacing="5.0">

As a former frontend dev I always prefer to separate UI from logic - from my perspective it makes code easier to read and maintain. You're right it comes with some costs, don't know how big these costs are - just want to be sure we are not falling into the trap of [premature optimization](https://wiki.c2.com/?PrematureOptimization).

If I'll find time I'll try to measure this problem a bit during refactoring we talked about here.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5963#discussion_r789640392
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5963/review/859516275 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220121/035c3f3f/attachment.htm>