[bisq-network/bisq] Add missing filtering on lists (PR #5963)

chimp1984 notifications at github.com
Fri Jan 21 14:22:40 CET 2022


@chimp1984 commented on this pull request.



>  <VBox fx:id="root" fx:controller="bisq.desktop.main.funds.deposit.DepositView"
       spacing="10" xmlns:fx="http://javafx.com/fxml">
     <padding>
         <Insets bottom="15.0" left="15.0" right="15.0" top="15.0"/>
     </padding>
-
+    <HBox spacing="5.0">

Yes the UI code in Bisq is pretty messy unfortunately. Clear separation can also be done in Java code of course.
It was not premature but a result of experience of laggy UI and then got changed and observed the performance improvement. In Bisq 2 we will not use FXML at all.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5963#discussion_r789652814
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5963/review/859535291 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220121/8f907daa/attachment.htm>


More information about the bisq-github mailing list