[bisq-network/bisq] Add API 'gettrades' method (PR #5976)

[Stan]

@ghubstan commented on this pull request.



> @@ -292,7 +298,10 @@ Trade getTrade(String tradeId) {
     List<TradeModel> getOpenTrades() {
         coreWalletsService.verifyWalletsAreAvailable();
         coreWalletsService.verifyEncryptedWalletIsUnlocked();
-        return tradeManager.getTrades().stream().map(t -> (TradeModel) t).collect(Collectors.toList());
+        return tradeManager.getTrades().stream()
+                .map(t -> (TradeModel) t)

It is something @xyz123 asked for in his review:  "why isn't the mapping consistent between return types for `List<TradeModel> getOpenTrades()` and ` List<TradeModel> getTradeHistory(...)`"?   I did intend make the return types consistent, but overlooked it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5976#discussion_r793499960
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5976/review/864719646 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220127/b4edb170/attachment.htm>