[bisq-network/bisq] Add API 'gettrades' method (PR #5976)

[Stan]

@ghubstan commented on this pull request.



>          } else {
             var failedV1Trades = failedTradesManager.getTrades();
-            return failedV1Trades.stream().map(t -> (TradeModel) t).collect(Collectors.toList());
+            return failedV1Trades.stream()
+                    .map(t -> (TradeModel) t)

It is something @xyz123 asked for in his review: "why isn't the mapping consistent between return types for List<TradeModel> getOpenTrades() and List<TradeModel> getTradeHistory(...)"? I did intend make the return types consistent, but overlooked it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5976#discussion_r793500330
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5976/review/864720160 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220127/cdfda0b2/attachment.htm>